search

BU-hammerTeam / PyHammer

A Python Spectral Typing Suite
MIT License
53 stars 14 forks source link

Equivalent Width Measurements #9

Open jvntra opened 8 years ago

jvntra commented 8 years ago

Hey All,

Could you include a code/GUI component of Pyhammer for the use of measuring equivalent widths please? I understand that the IDL version had such a function. Thanks

jbochanski commented 8 years ago

The IDL version had built in EW measurements. It did not have a GUI for measuring an arbitrary line. On Sun, Oct 23, 2016 at 2:34 PM JPVentura135 notifications@github.com wrote:

Hey All,

Could you include a code/GUI component of Pyhammer for the use of measuring equivalent widths please? I understand that the IDL version had such a function. Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BU-hammerTeam/PyHammer/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIK6poAO9FlltAiL1c6uNYLLh7wFyipks5q26iegaJpZM4KeNMH .

John Bochanski Assistant Professor of Physics Rider University johnbochanski.com

*Follow CLAS on social media:*
https://www.facebook.com/riderclas/ <https://www.facebook.com/riderclaes/>
https://twitter.com/RiderCLAS
https://www.instagram.com/riderclas/
zephyr5050 commented 8 years ago

We'll definitely take a look at this. Over time we hope to continue to improve the PyHammer and this might be a useful tool for future releases. Thanks for the suggestion!

jvntra commented 8 years ago

Thanks for the prompt responses and input everyone.

JP

zephyr5050 commented 7 years ago

Now that the official paper on PyHammer is accepted and soon to be published, we've sat down to begin the next round of updates to PyHammer. We've discussed this issue and have decided for the time being that we will not implement an equivalent width measuring tool. We feel that this feature, while it may be useful, does not align with the general goal of PyHammer. However, we will leave this issue open to allow others to weigh in. If this feature is heavily requested, we may choose to add it in. So please feel free to comment on whether or not you want this feature to exist in PyHammer.