BUGS-NYU / NYU-CS-Wiki-old

Centralized hub for NYU CS students to find opportunities, including events, blog posts with SWE Interns, tutorials and more!!!
MIT License
13 stars 5 forks source link

Add Algolia Search Feature #28

Closed Kn99HN closed 3 years ago

Kn99HN commented 3 years ago

Hmmmmm, Not sure why netlify is not building properly. Any idea @esilverm? People seems to run into similar problem with the algolia plugin so I have looked into that but it still doesn't build.

esilverm commented 3 years ago

Hmmmmm, Not sure why netlify is not building properly. Any idea @esilverm? People seems to run into similar problem with the algolia plugin so I have looked into that but it still doesn't build.

Looks like it has to do with your dot env file. Typically when im working with them I like to create examples named .env-example

with the variables empty so people can just plug it in and rename the file or whatever. How are we handling env variables on netlify?

esilverm commented 3 years ago

Also Happy April Fools Day 😂 😂

Screen Shot 2021-04-01 at 12 25 59 PM

Kn99HN commented 3 years ago

Looks like it has to do with your dot env file. Typically when im working with them I like to create examples named .env-example

I'm setting it in Environment Variables under Build & Deploy. It's supposed to work based on the blog I believe...

esilverm commented 3 years ago

Looks like it has to do with your dot env file. Typically when im working with them I like to create examples named .env-example

I'm setting it in Environment Variables under Build & Deploy. It's supposed to work based on the blog I believe...

Build works just had to clear cache so env variables get loaded

esilverm commented 3 years ago

While you're at it can you actually go ahead and update gatsby, just use the yarn upgrade-interactive command and upgrade all

esilverm commented 3 years ago

Can you try making that change and pushing again, I removed the plugin that may be causing this issue.

Kn99HN commented 3 years ago

While you're at it can you actually go ahead and update gatsby, just use the yarn upgrade-interactive command and upgrade all

I thought we are using npm?

esilverm commented 3 years ago

While you're at it can you actually go ahead and update gatsby, just use the yarn upgrade-interactive command and upgrade all

I thought we are using npm?

Are you not using yarn to manage your dependencies for this project??? How did you manage to change the yarn.lock file otherwise???

Kn99HN commented 3 years ago

While you're at it can you actually go ahead and update gatsby, just use the yarn upgrade-interactive command and upgrade all

I thought we are using npm?

Are you not using yarn to manage your dependencies for this project??? How did you manage to change the yarn.lock file otherwise???

Lolllllllll

~Anw, just gatsby right, and no other dependencies or do you want to upgrade everything including plugins?~ Nvm didn't read your message carefully. I'll upgrade them and push

esilverm commented 3 years ago

We should fix styling but that can come later. This should be fine to merge imo

Kn99HN commented 3 years ago

We should fix styling but that can come later. This should be fine to merge imo

Yeah I was about to say that. Styling for the searchResultBox is not great atm but the logic works for now.