BUGS-NYU / nyu-cs-wiki

The go-to guide for NYU CS students
https://nyucswiki.com
Creative Commons Attribution Share Alike 4.0 International
5 stars 19 forks source link

massive restructure #26

Closed sachiniyer closed 1 year ago

sachiniyer commented 1 year ago

This is opinionated, but when working on issue #18 it became apparent (at least to me) that the wiki as a whole needed some restructuring.

I have divided it into

There is not much content change (just a few additions), just a restructure.

I also added some other stuff

Again opinionated, and perhaps uncalled for. However, because the activity in this repo is limited, I think a restructure right now should be okay.

sachiniyer commented 1 year ago

Let me figure out why the github workflow is failing before review.

sachiniyer commented 1 year ago

Okay I have merged with main, passed the linter, and passed the test build.

I am ready for review @aminoa

aminoa commented 1 year ago

Hey, I finally got a chance to take a look. I really appreciate the improved diagrams, home page tiles, and software acknowledgement. I did break out the opportunities section into two categories: one for career, the other still called opportunities (basically representing the internal/external opportunities at NYU). So it's now like this.

Academics (same as before)

Career

Opportunties

Social (same as before)

If you disagree with this, I can revert this and we can come up with a different structure. My goal was to limit the folds to only one layer to make the site easier to navigate. Also, when the structure is decided, I can make new images instead of using the DALLE ones (the social one is a little bit creepy lol).

sachiniyer commented 1 year ago

Splitting Opportunities and Career

I was trying to represent the opportunities in two different ways:

  1. Based off of internal to NYU vs external to NYU:

    Represented in the TOC by Internal and External

  2. Based off of goal - jobs vs higher education

    Represented in the diagram on the Opportunities landing page

I'm not opposed to a restructure. If the goal was to keep the TOC one level deep, I would flatten the Professor Run and Student Run section.

The new structure could look like (that maintains one level deep)

New Images

Lol sure, no opposition.

If we do change the top structure, we may also want to add another widget specifically to the Feature List.

aminoa commented 1 year ago

reverted the new header change; I broke out fellowships and internships into separate folds in the opportunities section since I suspect there will be quite a few more pages for both categories. Followed your suggestion for putting all the internal opportunities grouped together (I put tags for student and professor though if you want to have it in the title of each page, I wouldn't mind).

Also here are the new images!

image

aminoa commented 1 year ago

also seems to fix #2 as well

sachiniyer commented 1 year ago

This looks good to me. I just made a few small changes

  1. Changed "Internal" to "NYU Internal" to make the meaning clearer
  2. Changed the sidebar position to keep "NYU Internal" at the top (this made the most visual sense to me
  3. Changed the ordering inside of "NYU Internal" to have Research, Labs, Clubs, VIP which also made the most sense to me
  4. Added a small description to the top page

I would propose merging if this looks good to you. I think it is a good settling place.

Also I love the new images. Way better than what I did.

sachiniyer commented 1 year ago

Also just quickly renamed the icon folder as the same images were in high and low res (so there is no point in having distinct folders anymore)

aminoa commented 1 year ago

Yep, looks great. I appreciate your work on this PR!