Closed sachiniyer closed 1 year ago
Let me figure out why the github workflow is failing before review.
Okay I have merged with main, passed the linter, and passed the test build.
I am ready for review @aminoa
Hey, I finally got a chance to take a look. I really appreciate the improved diagrams, home page tiles, and software acknowledgement. I did break out the opportunities section into two categories: one for career, the other still called opportunities (basically representing the internal/external opportunities at NYU). So it's now like this.
Academics (same as before)
Career
Opportunties
Social (same as before)
If you disagree with this, I can revert this and we can come up with a different structure. My goal was to limit the folds to only one layer to make the site easier to navigate. Also, when the structure is decided, I can make new images instead of using the DALLE ones (the social one is a little bit creepy lol).
I was trying to represent the opportunities in two different ways:
Based off of internal to NYU vs external to NYU:
Represented in the TOC by Internal and External
Based off of goal - jobs vs higher education
Represented in the diagram on the Opportunities landing page
I'm not opposed to a restructure. If the goal was to keep the TOC one level deep, I would flatten the Professor Run and Student Run section.
The new structure could look like (that maintains one level deep)
Lol sure, no opposition.
If we do change the top structure, we may also want to add another widget specifically to the Feature List.
reverted the new header change; I broke out fellowships and internships into separate folds in the opportunities section since I suspect there will be quite a few more pages for both categories. Followed your suggestion for putting all the internal opportunities grouped together (I put tags for student and professor though if you want to have it in the title of each page, I wouldn't mind).
Also here are the new images!
also seems to fix #2 as well
This looks good to me. I just made a few small changes
I would propose merging if this looks good to you. I think it is a good settling place.
Also I love the new images. Way better than what I did.
Also just quickly renamed the icon folder as the same images were in high and low res (so there is no point in having distinct folders anymore)
Yep, looks great. I appreciate your work on this PR!
This is opinionated, but when working on issue #18 it became apparent (at least to me) that the wiki as a whole needed some restructuring.
I have divided it into
There is not much content change (just a few additions), just a restructure.
I also added some other stuff
Again opinionated, and perhaps uncalled for. However, because the activity in this repo is limited, I think a restructure right now should be okay.