search

BUNPC / Homer3

MATLAB application for fNIRS data processing and visualization
92 stars 54 forks source link

GLM fix to run tcca without ss #102

Closed mayucel closed 2 years ago

mayucel commented 2 years ago

Issue: GLM skips tCCA regression when there is no ss channels even though there is Aux. Now this is fixed.

sstucker commented 2 years ago

@mayucel Pull request looks great! Thanks for going through these motions, I hope the WORKFLOW.md file was helpful.

It is linked from the CONTRIBUTING.md file which is linked from the README... CONTRIBUTING.md is the standard place to look for instructions on development and code submission.

But I will try to make it more clear where to find it.

As for your actual change: it looks like the change to line 505:

if if mlSSlst(iSS)==0 && isempty(Aaux) duplicates an if statement

Perhaps this is correct?

If you push additional commits to the mayucel:master branch from which this PR is directed, things will be updated and and we can merge this.

sstucker commented 2 years ago

Looks good