BUNPC / pysnirf2

Python package for reading, writing and validating Shared Near Infrared Spectroscopy Format (SNIRF) files
GNU General Public License v3.0
15 stars 11 forks source link

Add requirements to setup.py #13

Closed rob-luke closed 2 years ago

rob-luke commented 2 years ago

I tried to use pysnirf2 at https://github.com/mne-tools/mne-nirs/pull/421 but it errors complaining that it doesn't have termcolor installed. This is the error

/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/_pytest/assertion/rewrite.py:170: in exec_module
    exec(co, module.__dict__)
mne_nirs/io/snirf/tests/test_snirf.py:10: in <module>
    from pysnirf2 import validateSnirf
/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/pysnirf2/__init__.py:1: in <module>
    from .pysnirf2 import *
/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/pysnirf2/pysnirf2.py:10: in <module>
    import termcolor
E   ModuleNotFoundError: No module named 'termcolor'

I often get confused about python packaging, so I am not sure if this PR will actually fix the problem. Or should I just add the two packages to my own install script? I had hoped that all I needed to run was pip install pysnirf2

sstucker commented 2 years ago

Yes, thank you. I forget they need to be here in addition to here