Closed larsoner closed 1 year ago
I will merge and release this fix along with a fix to #38
I'm worried I used logging
incorrectly and pysnirf might not play nicely with other software that uses it. I am considering implementing the code suggested in #37, but also maybe just removing the logging functionality from pysnirf altogether
@sstucker assuming your test coverage is good enough you could smoke out logging issues by using pytest
to run your tests. As a side benefit you get a lot of cool stuff for free for testing
... if you want I'm happy to make that transition. And I can also fix the unit testing that appears to be broken
Something changed on GitHub's end that broke the testing. I've fixed it I think, try and rerun your check.
I would welcome the switch if you're convinced it's a good idea. I didn't have much experience with Python testing or logging when I built what you see here.
Done @sstucker , ended up needing to make a bunch of little changes/fixes here and there, feel free to look at the diff
and they're not explained well enough in comments let me know and I can add more comments or just reply to comments on GH
This looks good! Do MNE folks need this released ASAP?
No, I hacked in a monkeypatch.setattr
Not sure how to add a test since it seems to only come up when using
pytest
and you use bareunittest
, but when adding some code to MNE-Python I got:This fixes the error with the
*args
being passed tologger.info
by constructing the entire string.