BUStools / bustools

Tools for working with BUS files
https://bustools.github.io/
BSD 2-Clause "Simplified" License
88 stars 22 forks source link

Could bustools inspect support the same barcode file formats as bustools correct? #101

Open detrout opened 1 month ago

detrout commented 1 month ago

In the barcode parsing code in bustools correct https://github.com/BUStools/bustools/blob/master/src/bustools_correct.cpp#L711 it supports barcode files of the format

AAAA GGGG TTTT
- TTTT CCCC

While the barcode reader in https://github.com/BUStools/bustools/blob/master/src/bustools_inspect.cpp#L59 requires the cartesian product style file

AAAATTTT
GGGGTTTT
TTTTTTTT
AAAACCCC
GGGGCCCC
TTTTCCCC

Because of this if you bustools inspect with the multiple list format barcode list these inspect attributes will be 0.

  "numBarcodesOnOnlist": 0,
  "percentageBarcodesOnOnlist": 0.000000,
  "numReadsOnOnlist": 0,
  "percentageReadsOnOnlist": 0.000000
Yenaled commented 1 month ago

Thanks Diane! :) I’ll keep note of this and fix it when I upgrade bustools!