BUTR / MnB2-Bannerlord-CommunityPatch

This is going to be a mod that just fixes up some things in Mount & Blade 2: Bannerlord before the Devs & QA team can get to them. They have priorities and a process.
MIT License
88 stars 26 forks source link

Disciplinarian still not working. #4

Closed Ryutodabi closed 4 years ago

Ryutodabi commented 4 years ago

Don't know what I've done wrong, but I still don't have the ability to train bandit troops to normal infantry.

KenRiehle commented 4 years ago

Yeah same here I downloaded the patch also have 8 troops ready to upgrade and the box is still red and has the you need the perk statement. I triple checked my skills and I have the perk and a skill of 135 in Leadership... does it work for you the guy that created the mod if so what did you do differently?

Tyler-IN commented 4 years ago

Re-download the mod and set it up. Give it a try again. I had two lines switched around. My bad.

Tyler-IN commented 4 years ago

Oh - there's something else to cause it to not work, fixing it...

Tyler-IN commented 4 years ago

https://github.com/Tyler-IN/MnB2-Bannerlord-CommunityPatch/releases/tag/v0.0.1-hotfix1

Give that a shot and test it.

Ryutodabi commented 4 years ago

Uh, It's saying I need Peak Form.

SwankTrain commented 4 years ago

Same as Wesx, the requirement changes to Peak Form but it also auto allocates it regardless of my athletics level. I manually allocated Peak Form after disabling the mod, then re enabled it, and it is still displayed in red.

Tyler-IN commented 4 years ago

What the heck... ok, looking into it...

Tyler-IN commented 4 years ago

Crap, yeah there's some copy-pasta going on. Fixing it.

Tyler-IN commented 4 years ago

https://github.com/Tyler-IN/MnB2-Bannerlord-CommunityPatch/releases/tag/0.0.1-hotfix2

Give this a shot. Thanks for testing. I'm not getting enough time to play test it, I'm trying to work out a way to make automated unit tests.

slvrbuu commented 4 years ago

It still appears to require Peak Form, at least for me.

Tyler-IN commented 4 years ago

I'll post a screenshot in a sec of what it's supposed to look like...

slvrbuu commented 4 years ago

I'll start a new game. Maybe some kind of remnant is causing issues.

Tyler-IN commented 4 years ago

I am testing it on loading a game, not on new games. It should work on both.

image

slvrbuu commented 4 years ago

Oh, odd. With the mod enabled, Disciplinarian isn't even in the tree.

Tyler-IN commented 4 years ago

image

You might have the wrong version? Try hotfix2

Tyler-IN commented 4 years ago

Here's without being skilled up.... image image

Tyler-IN commented 4 years ago

And here's a screenshot of what it should look like when upgrade is possible... image And without the perk... image

slvrbuu commented 4 years ago

disc Yeah, I did some testing, even with no other mods, and cheat_mode = 0, it still doesn't show in the tree.

Tyler-IN commented 4 years ago

Alright, guess I need some environmental report functionality for the mod... I guess I need the versions of everything, the directory structure of the mod's path, and maybe some logs... I'll put together some diagnostic component.

slvrbuu commented 4 years ago

The mod is in D:\Games\Steam\steamapps\common\Mount & Blade II Bannerlord\Modules And my versions/load order is automatically set to: Native: e1.0.0 Community Patch v0.0.1 CustomBattle: e1.0.4 Sandbox Core: e1.0.4 Sandbox: e1.0.4 StoryMode: e1.0.4

Tyler-IN commented 4 years ago

yeah that looks right, what is the size and some hash of the dll?

slvrbuu commented 4 years ago

I'm not sure how to find the hash, but the size is 8KB.

Tyler-IN commented 4 years ago

Can you give me the exact size in bytes? It should be 8704.

slvrbuu commented 4 years ago

8192 bytes.

slvrbuu commented 4 years ago

Perhaps the version you uploaded is out of date?

Tyler-IN commented 4 years ago

Yep. Uploaded wrong file. Try that one - I edited the release.

slvrbuu commented 4 years ago

This one works. :D

Tyler-IN commented 4 years ago

Closing as resolved.

johnshepardn7117 commented 4 years ago

Character Development System patch 1.0.6

Fixed “Leadership Disciplinarian”