BUUPE / BUUPE.github.io

Official website of Upsilon Pi Epsilon at Boston University
https://upe.bu.edu/
MIT License
2 stars 3 forks source link

Refactor Profile IMGs #86

Open vitorvicente opened 4 years ago

vitorvicente commented 4 years ago

Refractor the profileIMG system to store the direct link to the image.

Rename /profiles to /memberData, then have a subfolder for each member with their UID has the key, and inside keep any files related to them.

This will required:

ROODAY commented 4 years ago

Also as part of this can we make the profile images consistently sized, right now they have width: 75% which makes sure they resize on different screens, but this makes it hard to ensure consistency (some are oval, some are circles, etc). An easy fix is to apply this to images:

width: 250px;
height: 250px;
object-fit: cover;

250px looks good on phones and desktop, but if you really want to keep the 75% width you'll need to write JS logic to resize the height to match width (feels unnecessary but up to you). You'll need object-fit regardless as that makes sure the images are centered and cropped regardless of dimensions.