BVE-Reborn / rend3

MAINTENCE MODE ---- Easy to use, customizable, efficient 3D renderer library built on wgpu.
https://rend3.rs
Apache License 2.0
1.05k stars 59 forks source link

Update `wgpu` dependency to 0.19.0. #567

Closed kpreid closed 5 months ago

kpreid commented 5 months ago

Checklist

Description

Updates wgpu to the new release 0.19.0.

kpreid commented 5 months ago

Incorporated updating wgpu-profiler.

kpreid commented 5 months ago

It occurs to me that there's a subtlety here — with wgpu 0.19 no longer having the webgl feature imply disabling WebGPU, this means that as long as rend3 depends on wgpu with default features, it'll be impossible to compile rend3 applications for web without using web_sys_unstable_apis. So, I think this change will also have to disable default features on the wgpu dependency, or it'll put users in a bad situation. (Unfortunately, this means that users will have to think about wgpu backend feature selection explicitly…)

kpreid commented 5 months ago

This should be ready to merge, in principle. Tests don't pass locally, though:

---- animation::test stdout ----
thread 'animation::test' panicked at /Users/kpreid/.cargo/registry/src/index.crates.io-6f17d22bba15001f/env_logger-0.10.2/src/logger.rs:479:14:
Builder::init should not be called after logger initialized: SetLoggerError(())
stack backtrace:
...
   4: env_logger::logger::Builder::init
             at /Users/kpreid/.cargo/registry/src/index.crates.io-6f17d22bba15001f/env_logger-0.10.2/src/logger.rs:478:9
   5: rend3_framework::App::register_logger
             at /Users/kpreid/Projects/rust/contributing/rend3/rend3-framework/src/lib.rs:74:9
   6: rend3_examples_package::tests::test_app::{{closure}}
             at ./src/tests.rs:17:5

I'm not sure what's up with that, but it seems to be a preexisting issue.

cwfitzgerald commented 5 months ago

I'm not sure what's up with that, but it seems to be a preexisting issue.

You need cargo nextest - I should implement the same "scream at you" error as wgpu has.

kpreid commented 5 months ago

You need cargo nextest

Then the testing steps in build.bash (and the PR template) are stale and should be updated or deleted, because they contain cargo test.

kpreid commented 5 months ago

Updated naga too to satisfy cargo-deny.

kpreid commented 5 months ago

@cwfitzgerald The mac CI failure has no details — failure to start perhaps?

In any case, what does this PR need to move forward?

cwfitzgerald commented 5 months ago

Yeah I pulled my local runner for security concerns - let's merge this and I'll fix it in a follow up.