Fix issues #570, #575

[John-Nagle]

Checklist

• CI Checked:
  • [X] cargo fmt has been ran
  • [X] cargo clippy reports no issues
  • [partial] cargo test succeeds (2 failures - scene-viewer tests need two.gltf files not present in the project, same as before.
  • [X] cargo rend3-doc has no warnings
  • [X] cargo deny check issues have been fixed or added to deny.toml
• Manually Checked:
  • [X] relevant examples/test cases run
  • [ ] changes added to changelog
  • [ ] Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

• Closes #570
• Closes #575

Description

Issue #570 required a mechanism to allow the application to override the default action of requesting a redraw immediately after redrawing each frame. So a new function, handle_redraw_done, was added to the App trait in rend3_framework. The default implementation of the trait mantains old behavior by requesting another redraw at the end of each redraw. Applications where the platform does not give non-redraw events priority over redraw events (this includes Windows executables running under Wine) can override the default behavior and redraw only when the event loop is about to wait.

Issue #575 was fixed by removing some dead code which imported "reqwest", pulling in but not using "tokio".

Also fixed the framework to allow the logger to be initialized more than once. This allows "cargo test" to run without panics.

[John-Nagle]

CI is failing because CI is using an old Rust compiler:

error: package `bumpalo v3.15.3` cannot be built because it requires rustc 1.73.0 or newer, while the currently active rustc version is 1.72.1
Either upgrade to rustc 1.73.0 or newer, or use
cargo update -p bumpalo@3.15.3 --precise ver
where `ver` is the latest version of `bumpalo` supporting rustc 1.72.1

Checking Bumpalo, here's the change that broke it: Fix MSRV in Cargo.toml; bump to version 3.15.1

Current stable Rust is rustc 1.76.0. Github continuous integration for Rend3 uses 1.72.

So the CI file needs an update.

[John-Nagle]

I can't fix the CI problem. I don't have permission to modify the CI workflow.

[cwfitzgerald]

@John-Nagle you can likely fix it, I just need to manually approve the CI run - this only happens on your first PR. On your second PR, CI will run automatically

[John-Nagle]

I got a Git permissions error trying to commit "@John-Nagle Increase Rust version in continuous integration from 1.72 to 1.76 so". I don't fully understand the restrictions on that.

[John-Nagle]

CI for mac is stuck waiting for a runner, for 23 hours now. All other runs finished in the first minute. Is that normal?

[John-Nagle]

How can I get this un-stuck? The mac CI waited 24 hours for a runner and then Github aborted the job.

[cwfitzgerald]

I can't push to your branch as it's trunk - but will merge this and fix it.