BVengo / simple-shulker-preview

A minecraft fabric mod that displays a configurable icon indicating the contents of a shulker box, as well as a capacity bar.
GNU Lesser General Public License v3.0
8 stars 8 forks source link

[Bug]: Two small bugs on 1.20.1 #19

Closed sternschnaube closed 1 year ago

sternschnaube commented 1 year ago

Describe the Bug

1 - If you stack two or more Shulker Boxes, the icon is overlapping.

image

2 - Example, if you take a stack from your inventory, right clicking the items one by one into a different slot in your inventory. You see this item flickering on the first Shulker Box in the row.

image

Steps to Reproduce

/

Expected Behavior

/

Screenshots

No response

Fabric Version

0.14.21

Mod Version

Latest Port to 1.20

Log Output

No response

Additional Context

No response

BVengo commented 1 year ago

Thanks for reporting this - I'll be looking further into it prior to the 1.20.1 version release.

BVengo commented 1 year ago

Hi again :) Which mods are you using in example 1? I tested against both tweakaroo and shulkerboxtooltip yet neither had the overlap issue. Could you please also check if decreasing your z position helps, because if it's too high it will overlap with tooltips.

I can't seem to replicate example 2 at all. Could you please test with other mods disabled to see if there is any interference?

sternschnaube commented 1 year ago

I really like the new "Show Capacity" Feature. Could you make it please possible to display this bar on top, or even to the sides? And a option to disabling it for stacked shulkers would be great - since they are full.

I was trying now to lower my Z value. Normal shulkers are 6 now, and stacked ones 5. It seems that the second bug is gone now.

But the first is still there, I will check which mod is creating this issue.

BVengo commented 1 year ago

Glad to hear you enjoy it! As you can see, I've added the capacity controls as a future feature because it's a pretty smart idea (and consistent with the rest of the mod).

Could you open a new issue for the stacked shulkers with a bit more detail? I'd like to keep all the feature requests seperated out for further discussion.

Finally, glad to hear your 2nd issue seems to be resolved now. I'll keep an eye out for your updates on the 1st one. Could you please also clarify what you mean by 'stacked shulkers'? I just want to confirm that we're on the same page for debugging this particular issue.

sternschnaube commented 1 year ago

It's nicee to have this indicator, but it makes for me no sense for stacked shulkers. Since the stacked shulker ones are always full. (17 stacked shulkers with sand)

Maybe another option to change the indicator color blue to something else. And being able to select a different color if a shulker is full / or you can disable it entirely.

image

I think we can close this and after I found out which mod is creating this issue, I open a new case for this. (The overlapping icon)

BVengo commented 1 year ago

I've now added an extra capacity control to the new issue to deal with that in the future.

I'll keep this issue open for troubleshooting your bug though, no need to create new ones.

BVengo commented 1 year ago

Closing now - I would have expected a couple more comments after the 1.20.1 release but I think we're all in the clear.

sternschnaube commented 1 year ago

Found not the time to looking further into it. I will come again to it when I spot the issue.