search

BVengo / simple-shulker-preview

A minecraft fabric mod that displays a configurable icon indicating the contents of a shulker box, as well as a capacity bar.
GNU Lesser General Public License v3.0
8 stars 8 forks source link

[Bug]: Mod causes PolyMc and ATLauncher to stall indefinitely on windows #9

Closed theendercore closed 2 years ago

theendercore commented 2 years ago

Describe the Bug

When downloading modpack (and mods have not test this though) on the PolyMC and AT Launchers it fully stops and does not continue do to illegal charter in the name. I found out about this when my friends tried to install the modpack i made. I use linux they use windows.

Steps to Reproduce

Install a modpack contain the mod on Poly and AT. Once it seams like all the mods will be downloaded it will stall on the mod (which can be seen in logs).

For reference the modpack i use (only v1.2.1 includes the mod) : https://modrinth.com/modpack/end-client/version/1.2.1

Expected Behavior

No to stall Poly or AT. And not to make windows cry.

Screenshots

No response

Fabric Version

No response

Mod Version

1.19.* v2.0

Log Output

No response

Additional Context

please fix this. its such a small issue but this mod is very cool and i would love if i could include it in my modpack.

theendercore commented 2 years ago

How to fix:

Replace * with x in the name

BVengo commented 2 years ago

Ouch, thanks windows! I use Linux too, so completely forgot that may be an issue.

I'll upload another version shortly - there's another bug that v2.1 will fix so I just need to double check that it's all working properly before I upload.

BVengo commented 2 years ago

Thanks for letting me know about that, it's an embarrassingly simple mistake!

I've updated releases on CurseForge, Modrinth, and GitHub to v2.1. See https://github.com/BVengo/simple-shulker-preview/releases/tag/v2.1 for changelogs. Let me know if you run into any further problems :) It's harder for me to test this on Windows unfortunately, but if you run into further OS-based issues then I'll spin up a VM for further testing.

theendercore commented 2 years ago

Thanks for fixing this so fast :) And is okay. I also would have forgotten then the Windows has in inferior file system. :)