Open zsmith27 opened 1 month ago
@AleneOnion
I have been thinking about removing non-detects ("U") from the RESULT_QUALIFIER field. It seems odd to include non-detects in the same field as reject (R), trend (T), and accepted (A) data. The latter categorize data into bins to inform data usage, while non-detects are additional information about the reported result. It is possible to have non-detects and be R, T, or A.
I propose we use DETECT_FLAG for identifying non-detecs and the RESULT_QUALIFIER to indicate how we recommend the data be used (e.g., R, T, or A).
That makes perfect sense to me
The DETECT_FLAG is part of NYSDEC's standard EDD. The definition I created in the data dictionary is:
The definition for this field in the EDD manual is:
However, this field was not retained in the previous lake database. Therefore, there are instances in the Oracle database where there are non-detects identified as "U" in the RESULT_QUALIFIER and LAB_QUALIFIER columns, but the DETECT_FLAG is "not_applicable". "not_applicable" was used as a catchall to categorize data that did not include a DETECT_FLAG field.
There are also non-standard character strings to this field attempting to provide more detail:
These character strings should likely be changed to "N". However, we will need to be cautious about this change if there are values in the RESULT_VALUE column.