search

BWibo / oracle-java-docker

Basic Dockerfile for Oracle Java
Apache License 2.0
0 stars 0 forks source link

Support java 8? #1

Open cha0s opened 3 years ago

cha0s commented 3 years ago

I am going to try building java 8 support so I can use oracle java for minecraft servers. I figured I'd file the ticket though in case it's something you want to implement yourself (you probably know better than me anyway :))

I just noticed that e.g. the .tar.gz filename is different right off the bat, but there may be other things that need to be adjusted.

cha0s commented 3 years ago

It was actually relatively straightforward to accomplish this with build args:

docker build --build-arg JAVA_FILENAME=jre-8u291-linux-x64.tar.gz --build-arg JAVA_VERSION=jre1.8.0_291 .

Note that I'm using jre instead of jdk (maybe worth another build arg), but everything seems to work ok so far.

Maybe a note in the README about this would prevent dumb people like me making unnecessary issues :P

Anyway, I'll let you close it or whatever you'd like once you have a read.