Bootcamp - UML review - Githubissues

BWilkins708 / Bootcamp

0 stars 0 forks source link

Bootcamp - UML review #1

Open mandyWW opened 2 years ago

mandyWW commented 2 years ago

Great work Brook, just a few comments below..

Use case diagram

add system boundaries around the Customer App, Restaurant App and Delivery App
make sure you use verb phrases e.g. "information on when food will arrive" should be "view order progress"
"Order/pay for food", split into 2 use cases

Class diagram

a little too much inheritance here! Have a read through https://multiverselearningproducts.github.io/curriculum/Bootcamp/Unit-1-Object_Oriented_Programming/0.1.0-UML_Modelling.html#javascript to choose the correct relationship types eg. Customer places 0..* Order would be shown just with a plain straight line.

Sequence diagram

almost perfect but no need to save the location in the database, just retrieve restaurants which match/near to the location

BWilkins708 commented 2 years ago

Thank you, I have completed and uploaded the improvements you set.