search

BYTE-Club-CCNY / byte

our website!
https://byteccny.com/
MIT License
3 stars 1 forks source link

Firefox support #30

Closed LordFarquaadtheCreator closed 4 weeks ago

LordFarquaadtheCreator commented 1 month ago

Website broken on firefox - seems to be aceternity's fault. High priority!

Evandabest commented 4 weeks ago

The problem

The component library seems to be incompatible with older versions of NextJs for Firefox specifically. Aceternity came out a few months ago while NextJs 13 came out almost two years ago. Below I have attached a gif of one of the components fully working on Firefox using NextJs 14, compared to the NextJs 13 version.

Kapture 2024-06-05 at 09 56 59

Solution

We have to upgrade to NextJs 14 for the component to properly render. However, upgrading to NextJs 14 will come with some trade offs. We will not be able to use the Cypress testing framework and we have to carefully review our code. Simply running

npm i next@latest react@latest react-dom@latest eslint-config-next@latest

won't work as expected. The components still seem to be static after trying this on a local copy as seen below.

Kapture 2024-06-05 at 11 02 01

LordFarquaadtheCreator commented 4 weeks ago

Installed using bun, works there. Tried running with node - works as well. Maybe its an npm issue? Regardless, I'll try deploying this new version to amplify and see how it runs.

LordFarquaadtheCreator commented 4 weeks ago

Migrated, but didnt resolve

LordFarquaadtheCreator commented 4 weeks ago

fixed in main - it was a tailwind css issue that wasnt fully supported on firefox