Indv project pages - Githubissues

BYTE-Club-CCNY / byte

our website!

https://byteccny.com/

MIT License

3 stars 1 forks source link

Indv project pages #37

Closed jaynopponep closed 6 days ago

jaynopponep commented 1 week ago

added pop up page desired
updated correct (new) endpoint for retrieving data
removed unused project files/code
edited design of the carousel and the pages themselves
able to view each project on github with a button

LordFarquaadtheCreator commented 1 week ago

looking good, minor knitpick:

remove the ":" colons
center the text

LordFarquaadtheCreator commented 1 week ago

interestingly, the centering issue doesnt appear in the (QA environment)[https://exp.d1ud9ybook8aha.amplifyapp.com/]. I could've sworn I mentioned it before, but can we make the carasoul scrollable?

jaynopponep commented 1 week ago

looking good, minor knitpick:

remove the ":" colons

center the text

Ill take a look For the scrollable, might be tricky with the original component since I can't seem to find a specific horizontal scroll bar, but it does have arrow keys for changing the slides: https://www.embla-carousel.com/examples/predefined/

LordFarquaadtheCreator commented 1 week ago

For the scrollable, might be tricky with the original component since I can't seem to find a specific horizontal scroll bar, but it does have arrow keys for changing the slides:

try the overflow: scroll css property if that doesnt work then try the arrows

jaynopponep commented 6 days ago

Removed colons
Added arrow keys for navigation (removed thumb keys/small buttons) @LordFarquaadtheCreator It's not clear whether the centering is still an issue since I've tried on other browsers, and it also looks fine on this branch and on the experimental link you sent like you said