search

BYTE-Club-CCNY / leetcode-tracker

2 stars 0 forks source link

Detect submission #22

Closed mnk0015 closed 4 months ago

Abdul-Andha commented 4 months ago

Made some changes. Review them and lmk what you think @mnk0015

mnk0015 commented 4 months ago

Made some changes. Review them and lmk what you think @mnk0015

These are good. The text area would include the button but also the text on top if I am not mistaken. Also, I forgot to mention in the meeting about the shortcut submissions. The shortcut submissions are related to mac where I am pretty sure you can press a keyboard shortcut to submit.

Abdul-Andha commented 4 months ago

The text area would include the button but also the text on top if I am not mistaken.

Why do we need that text to detect submission?

The shortcut submissions are related to mac where I am pretty sure you can press a keyboard shortcut to submit.

Okay got it. Given that we are short on time and the v2 submit is not working as expected right now anyway (it only works on the first click of submit), lets just focus on v1 for mvp/demo. We can add v2 and shortcut coverage later.