search

BYU-Hydroinformatics / tethysapp-tethys_app_store

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Tethys App Store Name #12

Closed swainn closed 2 years ago

swainn commented 2 years ago

I noticed that the repository has been renamed "app_store". I have a few suggestions:

Also, renaming the repo doesn't actually rename the app. I recommend doing the following:

swainn commented 2 years ago

Thought of a few other things related to renaming:

danames commented 2 years ago

Agree with all. Rohit has been working to rename everything so this is good input.

Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA Past-President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames https://ceen.byu.edu/directory/dan-p-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ

On Wed, Aug 18, 2021 at 11:01 AM Nathan Swain @.***> wrote:

Thought of a few other things related to renaming:

  • Documentation and README need to be updated
  • Conda and/or pip packages need to be made with new name

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BYU-Hydroinformatics/app_store/issues/12#issuecomment-901277309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2PZ5AGAMZD3HWOG4HGSLDT5PRNJANCNFSM5CMNF6LQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

rileyhales commented 2 years ago
  • Better: Change the app package and URL root for the app to "app_store" and "app-store"

I agree with this but we need to double check this url changes won't break any of the github actions workflows we built. Or at least sync updating both.

rileyhales commented 2 years ago

Have we thought about the ramifications of the name changes to the draft of a paper in the EMS peer review phase? I think we should definitely try to get the paper to reflect the name change or i would become unsure if its wise to rename.

Next time we have a chance to do edits we can edit it and make a note that we reconsidered the propose warehouse name for various reasons.

danames commented 2 years ago

Rohit is working on revisions to the EMS paper at the same time, so we're going to push through the name change in both places...

Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA Past-President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames https://ceen.byu.edu/directory/dan-p-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ

On Wed, Aug 18, 2021 at 1:34 PM Riley Hales @.***> wrote:

Have we thought about the ramifications of the name changes to the draft of a paper in the EMS peer review phase? I think we should definitely try to get the paper to reflect the name change or i would become unsure if its wise to rename.

Next time we have a chance to do edits we can edit it and make a note that we reconsidered the propose warehouse name for various reasons.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BYU-Hydroinformatics/tethysapp-tethys_app_store/issues/12#issuecomment-901376501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2PZ5AA74IYXZSJZB3IQZDT5QDN3ANCNFSM5CMNF6LQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

rfun commented 2 years ago

Thanks for all the suggestions @swainn. The new version has been pushed out and the app has been renamed accordingly. Please let me know if you see any issues. Closing this issue for now.