Rename to App Store - Githubissues

BYU-Hydroinformatics / tethysapp-tethys_app_store

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

Rename to App Store #15

Closed rfun closed 2 years ago

rfun commented 2 years ago

This should hopefully complete the rename for the warehouse to app store. there might be too many files to review so the easiest way to test would be to pull this branch rename and try installing it locally.

Once this is merged I will push out a build with the new name after resolving the merge conflicts.

rileyhales commented 2 years ago

Looks good. I fresh installed and built the docs. Everything looks ok. 1 thing to be fixed.

On the app's page in a portal, the question mark button to open the help model doesn't do anything. Should fix this while we're here.

3 other things that maybe don't have to be fixed in this pull request:

The screenshots in the docs show the old name. We should fix that before this project is "finished" and other people need to start consulting the docs for help.
Also for the docs, there are several blank pages. Some of these pages could be moved from separate pages to subheadings on existing pages.
The example code on docs/github install api/github action example has a comment about changing the URL in the yml which should be changed. This is higher priority than the other 2 but i would suggest it should happen in a separate pull request to synchronize the docs changes with the updated installation on tethys-staging.

rileyhales commented 2 years ago

Also- the link to readthedocs still doesn't work. We currently have app-store.readthedocs and tethys-app-store.readthedocs listed on the readme but neither work. This needs to be added to readthedocs.

rileyhales commented 2 years ago

I approved but i would really recommend we put this on readthedocs asap. i believe you will be required to use the url tethysapp-tethys_app_store.readthedocs.io because thats the name of the repository at the time you submit it. So there will be more changes to the pr to get the urls to the docs correct. @rfun you could ask nathan if he would let you subdomain tethysplatform.org e.g. you can put your docs at app-store.tethysplatform.org or something like that. You just need whoever owns the domain to add a cname or A record

rfun commented 2 years ago

I approved but i would really recommend we put this on readthedocs asap. i believe you will be required to use the url tethysapp-tethys_app_store.readthedocs.io because thats the name of the repository at the time you submit it. So there will be more changes to the pr to get the urls to the docs correct. @rfun you could ask nathan if he would let you subdomain tethysplatform.org e.g. you can put your docs at app-store.tethysplatform.org or something like that. You just need whoever owns the domain to add a cname or A record

@rileyhales : Thanks for all the comments. I agree with most of these suggestions and will work on getting them resolved later today.