BYU-Hydroinformatics / tethysapp-tethys_app_store

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

"lake" app installed #2

Closed danames closed 3 years ago

danames commented 3 years ago

I just deleted all my apps manually, uninstalled, removed the folders, etc. Then grabbed latest warehouse from github, installed it, and started it. It shows that I already have an app installed called "lake". What is that? image

rfun commented 3 years ago

So the reason this is happening is because when we search if an application is installed or not, the search is a wildcard type of search to ensure that we find the package if it is installed. In this case it finds the flake8 package and thinks that its the lake app since it contains the words lake We need to either force it to search the exact name. Thanks for posting this issue.

danames commented 3 years ago

Wow! interesting side case that we may not have found had it not been for the lake app!


Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/faculty/person/Daniel-P.-Ames http://ceen.et.byu.edu/content/dan-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ


On Tue, Oct 6, 2020 at 12:32 PM Rohit Khattar notifications@github.com wrote:

So the reason this is happening is because when we search if an application is installed or not, the search is a wildcard type of search to ensure that we find the package if it is installed. In this case it finds the flake8 package and thinks that its the lake app since it contains the words lake We need to either force it to search the exact name. Thanks for posting this issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BYU-Hydroinformatics/warehouse/issues/2#issuecomment-704469018, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2PZ5E4T5KVAHSW4MUXH5TSJNPDPANCNFSM4SGJF6AA .

rfun commented 3 years ago

Fixed in version 0.2.4

danames commented 3 years ago

confirmed