search

BYU-ODH / cambodian-child-theme

Wordpress theme for the Cambodian Oral History Project
0 stars 0 forks source link

Copyright year in footer should be dynamic #44

Closed briancroxall closed 3 years ago

briancroxall commented 3 years ago

Since WordPress knows dates, this seems like something we could call relatively easily.

kwoods8 commented 3 years ago

I've found several methods for dynamic generation of a copyright year. Just waiting to get feedback from Tory.

kwoods8 commented 3 years ago

Made it dynamic and also did some styling edits: image

Current footer for comparison: image

Thoughts?

briancroxall commented 3 years ago

I think it looks generally good. Copyright notices tend to include mention of the copyright holder, so adding The Cambodian Oral History Project back to the statement would be good.

kwoods8 commented 3 years ago

NOTE: The site is about to be cloned, so you won't see these changes if you check this morning, but I've saved the code and made notes on my own machine, so I'll have those changes implemented after the cloning this afternoon.

Added site title: image

Also, styled for mobile: image

kwoods8 commented 3 years ago

Site has been cloned, and I've redone the footer edits: image image

Any other changes?

briancroxall commented 3 years ago

Looks good. Let's implement on production.

kwoods8 commented 3 years ago

On production! image

briancroxall commented 3 years ago

Woot!