search

BYU-ODH / hlrdesk

https://hlrdesk.hlrdev.byu.edu/
MIT License
0 stars 2 forks source link

changed the variable callNum to origCall which is returned from delInfo #357

Closed stevethomas19 closed 8 years ago

stevethomas19 commented 8 years ago

No variable callNum was being returned from object delInfo. I changed it to origCall (which was being used correctly to write the history of the item) and now it seems to be working properly.

Also, I have a question. We write the history of the item after we delete it from the db. Why? What purpose does that serve?

webnard commented 8 years ago

Also, I have a question. We write the history of the item after we delete it from the db. Why? What purpose does that serve?

Ahhh, good question. Can you see if deleting the item keeps the history? And can you verify that this deletes items?

My guess is that because of foreign key constraints, you still won't be able to delete items with this patch.

trevren11 commented 8 years ago

@stevethomas19 I think we are writing to the history for the case that we accidentally delete something or want to see when something was deleted.

stevethomas19 commented 8 years ago

@webnard The item history is a different table, so the history is saved. Here is a screenshot..

My guess is that because of foreign key constraints, you still won't be able to delete items with this patch.

This seems to be working. Here is a video that checks the database after I delete and it appears to work. http://screencast.com/t/ErtYUInBCr2Y

webnard commented 8 years ago

@stevethomas19 Okay, cool. Looks good to me then. I just looked through the database schema and we should be fine. Just a note that the database prevents you from deleting an item that is currently checked out.