search

BYU-ODH / wp-humanities-byu

Humanities theme following BYU Official style
2 stars 0 forks source link

Cleanup style.css for public consumption #453

Open WorldsEndless opened 2 years ago

WorldsEndless commented 2 years ago

Currently style.css is about 7000 lines. Can we reduce it to under 1000, including comments?

Remember to check both public pages and the admin dashboard/interface

spencercheng commented 2 years ago

Two options for getting an offline version of HTML classes. https://www.httrack.com/html/index.html https://wordpress.org/plugins/simply-static/

Comment out large chunks of styles and add them back in.

WorldsEndless commented 2 years ago

using httrack you could download all the final html, and then in vscode you can search it for whether that style class is actually used. Then you can comment it out in the real style.css and, at the end of the day, if things look the same with all the commented-out sections, you can straight up delete them.

spencercheng commented 2 years ago

@WorldsEndless Since there are currently no unassigned tickets, I was wondering if @julianayue could help with this ticket since issue #473 is almost resolved. A suggestion would be I could work on lines 0-4000, while she works on the rest. (4000-6500). What are your thoughts?

WorldsEndless commented 2 years ago

sounds great!

spencercheng commented 2 years ago

I found something that looks to be something that could help speed up the process of doing this ticket. In the inspect tool their is a section called coverage, and it lets us know what css styles is being used. The one's in blue means used and the red means it isn't. What are your thoughts? @WorldsEndless image

spencercheng commented 2 years ago

Check individual pages for different selector uses. Different ways to make it more responsive.

WorldsEndless commented 2 years ago

closed by #495

WorldsEndless commented 1 year ago

Did these changes go away? There are still over 6000 lines in style.css

WorldsEndless commented 1 year ago

@rosesxmarie I believe we talked about this issue, but I forgot to assign it. It is largely a git exploration: what happened to the massive down-sizing that was previously accomplished?