BYU-ODH / wp-humanities-byu

Humanities theme following BYU Official style
2 stars 0 forks source link

Directory results don't show up with details on search #490

Closed WorldsEndless closed 2 years ago

WorldsEndless commented 2 years ago

like https://odh.byu.edu/?s=russell . His diretory page is linked, but without any of the details that are meant to be included like at https://odh.byu.edu/people/?search=russel

The same is true of projects.

spencercheng commented 2 years ago

Seems like searchform.php and search.php could be the cause of this

WorldsEndless commented 2 years ago

https://developer.wordpress.org/reference/functions/get_post_type/

spencercheng commented 2 years ago

https://docs.pods.io/code/pods/

spencercheng commented 2 years ago

After my meeting with @kwoods8 today, we both thought it would be a better Idea that all the Post types look stylistically similar, otherwise it would be very uncanny having multiple styles in one page. For example, if we were to put tory in the search field, it would return more than one post types including persons, blogs, pages etc. To render those like how they are originally we think would defeat the purpose of a search page.

I know that I missed alot of details that we discussed. @kwoods8 please feel free to chime in!

WorldsEndless commented 2 years ago

Excellent points about the UI cohesion. However, the ultimate in uniformity is the google search on just this site -- but we can do better than that. We should include extra information available to shorten the search process: when the result is a directory page, show their email and phone; when a project, share the project owner and maybe some of the text.

To avoid style clash, I recommend using a vertical layout with a clear division between each result, so there is no "side-by-side" comparison overload happening.

spencercheng commented 2 years ago

Search Description for Persons : image

Search Description for Projects: image

spencercheng commented 2 years ago
spencercheng commented 2 years ago

image

spencercheng commented 2 years ago

Would we want an icon for the Name as well? @WorldsEndless

WorldsEndless commented 2 years ago

No, no icon for name. Mostly exactly what you see in the example above.

spencercheng commented 2 years ago

Okay! Sounds good.

spencercheng commented 2 years ago

image Images centered. Icons and Research Areas Show.

spencercheng commented 2 years ago

image Projects - Project Owner Show Images Centered Excerpts Show.