BYU-ODH / wp-humanities-byu

Humanities theme following BYU Official style
2 stars 0 forks source link

"projects" should be line-separated on individual profile page #491

Closed WorldsEndless closed 2 years ago

WorldsEndless commented 2 years ago

styling issue. On mobile, it is hard to distinguish projects categories from each other, such as "active". Perhaps a line separation.

image

above is mobile view of https://odh.byu.edu/person/tory-anderson/

WorldsEndless commented 2 years ago

Also, the category titles should not be smaller than their contents. It looks like h4 does the trick

kwoods8 commented 2 years ago

image

Changed the headings to make them a little more distinct.

kwoods8 commented 2 years ago

image

I don't think a line separation looks great, especially because it's a style we don't use anywhere else on the page.

kwoods8 commented 2 years ago

image

What if we had some white space between the categories?

WorldsEndless commented 2 years ago

More white space is probably the right answer, although I like the separating lines. But go with the whitespace as long as it's responsive for different screen sizes; this is probably a more "correct" solution from a design perspective.

kwoods8 commented 2 years ago

@WorldsEndless When you say responsive, do you mean we don't want whitespace on a desktop screen? Or that the size of the whitespace should adjust with the screen size?

WorldsEndless commented 2 years ago

The latter. It should be equally functional and equally pleasant across sizes