search

BYU-ODH / wp-humanities-byu

Humanities theme following BYU Official style
2 stars 0 forks source link

Improve styling UI of the nav menu #510

Closed WorldsEndless closed 2 years ago

WorldsEndless commented 2 years ago

Everything in the nav that now has "hover over" to cause underlining should also be clickable as the link. This is a minor DOM change.

image

spencercheng commented 2 years ago

Which file should I be looking to edit the nav bar? All I'm seeing is the function wp_nav_menu()

WorldsEndless commented 2 years ago

This can be improved by changing the padding on the nav items to margin, instead. However, the units also need to be changed for responsiveness. Not PX but something responsive live REM.

spencercheng commented 2 years ago

This is what the nav bar looks like after changing the unites to REM and from Padding to Margin. image Compare with the Original: image

spencercheng commented 2 years ago

You can't really see a difference from the images uploaded, but the top and bottom margin are bigger than the original nav bar even using 1REM. What are your thoughts on using 1vh/vw? @WorldsEndless

spencercheng commented 2 years ago

@WorldsEndless These changes I believe have been pushed up on Branch styleFixing521. We should probably fix this asap.

spencercheng commented 2 years ago

I've made the margin-top and bottom to be 1vh because 1rem is bigger than the original nav bar.