BYUCamachoLab / simphony

A simulator for photonic integrated circuits.
https://simphonyphotonics.rtfd.io
Other
119 stars 35 forks source link

Ideal Coupler model phase #101

Closed parkeraa closed 1 year ago

parkeraa commented 1 year ago

The s-parameters of the Ideal Coupler don't seem right. At best they ignore phase.

cjcarver commented 1 year ago

Definitely a bug. Fixed in 5a02a7c.