search

BYUCamachoLab / simphony

A simulator for photonic integrated circuits.
https://simphonyphotonics.rtfd.io
Other
119 stars 35 forks source link

Jax error when assigning arrays #88

Closed Andeloth closed 1 year ago

Andeloth commented 1 year ago

https://github.com/BYUCamachoLab/simphony/blob/5159848376a25114ecd4d2f0d9aa4c86a96bf2e1/simphony/simulation/classical.py#L75C15-L75C15

These lines throw errors when jax is enabled since jax arrays can't be assigned new values.

sequoiap commented 1 year ago

Fixed in 45980e46a9fa8bc1f47fe39bdad017645314367e