BYUCamachoLab / simphony

A simulator for photonic integrated circuits.
https://simphonyphotonics.rtfd.io
Other
119 stars 35 forks source link

Disconnected components within a circuit #97

Open parkeraa opened 1 year ago

parkeraa commented 1 year ago

Say I'm building a complex circuit with many components. I have many inputs that I want to make into a subcircuit for convenience, but they don't all connect yet. I want to be able to add components to a circuit without connecting them together. This would mean that components can exist in a circuit without being connected, and the resulting S matrix would (maybe) need to be split back up if the parts are connected to things later. At the very least, care would need to be taken so that the S matrix elements could be properly matched with their components' ports.

sequoiap commented 1 year ago

Decision: We will support disconnected circuits within a Circuit but also raise a warning when s_params is called. The warning can be deactivated with a flag on the object itself.