search

BYVoid / OpenCC

Conversion between Traditional and Simplified Chinese
https://opencc.byvoid.com/
Apache License 2.0
8.36k stars 974 forks source link

Fix macos not building with cpp 14 compat #744

Closed AntonOfTheWoods closed 1 year ago

AntonOfTheWoods commented 1 year ago

Fixes https://github.com/BYVoid/OpenCC/issues/743

From my testing this forces both the macos-11 and macos-12 github build images to use the proper compatibility, and builds all wheels for mac successfully.

AntonOfTheWoods commented 1 year ago

@ayaka14732 , I created a build job that does everything that the release to pypi job does, without pushing the wheel to pypi and tested that. Both the macos-11 and macos-12 images seem to build fine. This should fix the build issue with macos.

AntonOfTheWoods commented 1 year ago

Thanks @ayaka14732 . I'm not sure what the protocol is here. My understanding is that you should now just be able to run the release job and, if the compile gods smile, it should redeploy correctly. It might fail to push to windows and Linux (I might be remembering wrong though) but should succeed to Mac, and that is what we are after anyway.

If you want a version bump then let me know and I'll do that first thing tomorrow

ayaka14732 commented 1 year ago

I am going to run the release job again