cmake: hardcode less - Githubissues

BYVoid / uchardet

An encoding detector library ported from Mozilla

Other

605 stars 106 forks source link

cmake: hardcode less #28

Closed Coacher closed 8 years ago

Coacher commented 8 years ago

Also, I've noticed that currently CMakeLists.txt has a bit messy variable names: some of them have DIR prefix, others have CMAKE prefix, and to override the default values one needs to define variables without any specific prefix. Maybe use this instead?

Jehan commented 8 years ago

I am not a CMake expert and welcome any proposition which makes sense. I guess using GNU naming is a good idea and indeed makes sense.

Jehan commented 8 years ago

Merged. Thanks. Feel free to propose GNU variable naming in another pull request.

Coacher commented 8 years ago

Feel free to propose GNU variable naming in another pull request.

Will do. Hopefully soon.