search

BYVoid / uchardet

An encoding detector library ported from Mozilla
Other
609 stars 107 forks source link

(MSVC) Export functions correctly #35

Closed sgqy closed 7 years ago

Jehan commented 7 years ago

Hi @sgqy! Thanks for the patch. As explained on the README, this repository is not the upstream anymore (only kept for historical reasons, I'd say). We are now hosted at Freedesktop. Could you post this patch and any subsequent one to: https://bugs.freedesktop.org/enter_bug.cgi?product=uchardet ?

Also I've checked out your patch. Is there a way to be MSVC-friendly without polluting the main header with MSVC-specific code? uchardet.h is the public API/face of uchardet and I would like to keep it as simple and generic as possible with only its bare functions.

sgqy commented 7 years ago

@Jehan This may be a solution. But I've not learnt cmake. I will try to find another way to make it true.

Jehan commented 7 years ago

Awesome! Will wait for your patch with impatience. :-)