BaReinhard / Hacktoberfest-Data-Structure-and-Algorithms

A repo to contains data structure s and algorithms, regardless of language.

https://bareinhard.github.io/Hacktoberfest-Data-Structure-and-Algorithms/

GNU General Public License v3.0

225 stars 707 forks source link

Create any data structure in any language #60

Open BaReinhard opened 7 years ago

BaReinhard commented 7 years ago

Be sure to follow the structure data_structures/general/specific/language/file.lang

Ex data_structures/binary_tree/javascript/BST.js

BaReinhard commented 7 years ago

No preferences as of now. Whatever you feel like experimenting with.

JHenderson333 commented 7 years ago

Will implement Java Linked List

srpurwaha201 commented 7 years ago

Can i implement linkedList in c++?

m-sameer commented 7 years ago

Please merge my PR which will complete issue #133 and also this one.

kush-manchanda commented 7 years ago

I want to add a Graph in Java using Hashmap and Linkedlist , how should I proceed . I wish to create a folder 'Java' under Data Structures/ Graph and then add my files .

m-sameer commented 7 years ago

Here's what you do: 1.) Fork this repo. 2.) Clone your repo on your local machine. 3.) Go to Data Structures/Graph and create a new folder named "java". 4.) Add your files to that folder. 5.) Push it your remote repo. 6.) There should a 'create a pull request' button, click on it. 7.) Add the title and the description to the PR(and don't forget to mention this issue in the PR. You can mention it by adding 'Does #60' in your description). My suggestion would be to add 'Add Graph implementation in Java' as title and 'Closes issue #60' as the description. And you're done! (Ask anything that you didn't understand).

kush-manchanda commented 7 years ago

I added graph in java PR #275 . Do tell me how can I improve it , also I read the issue #133 just now , so didn't add any explanation .

m-sameer commented 7 years ago

Change the title of your PR to 'Add Graph's implementation in Java' and change the description to 'Added Graph's implementation in Java for issue #60'. I think that'll be enough. :)

kush-manchanda commented 7 years ago

Done and thanks for helping me out ! :D

m-sameer commented 7 years ago

Cool. ;). Welcome.

gunanksood commented 7 years ago

hey! i want to add a graph problem in c++. Assign this issue to me @BaReinhard

gunanksood commented 7 years ago

i have added Application of DFS algorithm to find largest component in a matrix. please merge the PR #327

jasm123 commented 7 years ago

Can I add a graph in Java?

m-sameer commented 7 years ago

No, @Kushredoc did that already. You have to use a different language or choose another Data Structure. Sorry.

jasm123 commented 7 years ago

Okay, then can I add a Segment Tree or Suffix Array in Java ? Also, in Graph, I've added DFS, BFS and topological sorting in addition.

m-sameer commented 7 years ago

The folders don't exist as of now so you need to create the folders yourself. Other than that, it's all great(just remember to create the BFS, DFS and the topological sorting folders in the Graph folder). Create a new folder in the folders of Data Structure named 'Java'. Add them in different PRs(you may need to create different branches to have a clean commit history and not having the changes overlap).

jasm123 commented 7 years ago

Yes, sure. Will do them in a day. Thanks!

m-sameer commented 7 years ago

Welcome! :-)

jasm123 commented 7 years ago

Created seperate folder and have submitted PRs for segment tree. I didn't submit PR for BFS, DFS because it is already there in algorithms folder.

m-sameer commented 7 years ago

Cool.