search

BabDev / Pagerfanta

Pagination library for PHP applications with support for several data providers
Other
383 stars 170 forks source link

Fix deprecation warning #16

Closed matthiasschobner closed 3 years ago

matthiasschobner commented 4 years ago

Because of this lines, it will be thrown deprecation warnings no matter if you implements the "Exception" interface. This fix the warnings. But i am not sure if this are a breaking change for those who use this bundle. For me this works.

mbabker commented 4 years ago

Unfortunately this is a B/C break because it changes the implemented interfaces on those exceptions, so a catch statement or instanceof check wouldn't work anymore on the deprecated interface.

mbabker commented 3 years ago

Closing, as is this would be a B/C break for the 2.x branch and the warnings are gone on 3.x.