Add generics notation to Pagerfanta class

BabDev / Pagerfanta

Pagination library for PHP applications with support for several data providers

Other

381 stars 170 forks source link

Add generics notation to Pagerfanta class #23

Closed emodric closed 3 years ago

emodric commented 3 years ago

This solves PHPStan issues in 3rd party code similar to this:

  32     Method App\CollectionPager::renderCollectionPager() has parameter $pagerfanta with no value type specified in iterable type                        
         Pagerfanta\Pagerfanta.                                                                                                                                                                                    
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type

On merge to 3.x, this notation should be moved to PagerfantaInterface

mbabker commented 3 years ago

Thanks!

emodric commented 3 years ago

Thank you @mbabker ! When can we expect a tag with this included? :)

mbabker commented 3 years ago

2.7.0 is tagged which includes these changes.

emodric commented 3 years ago

Thanks @mbabker :heart: