BabDev / Pagerfanta

Pagination library for PHP applications with support for several data providers
Other
381 stars 170 forks source link

Interface the Route Generator? #8

Closed mbabker closed 4 years ago

mbabker commented 4 years ago

In the bundle, I created a RouteGeneratorInterface to describe the callable that is used for generating paginated URLs. Would there be value in deprecating the existing callable $routeGenerator signatures in favor of the typed PHP class? Note, I wouldn't change the interface signature, so it would still fulfill the callable typehint, but if the interface is added in at some point the requirements would change to require that instead of any callable.