search

Baboo7 / strapi-plugin-import-export-entries

Import/Export data from and to your database in just few clicks.
179 stars 95 forks source link

[BUG] Cannot find module 'request' #96

Closed diacu closed 1 year ago

diacu commented 1 year ago

Describe the bug request was replaced with node-fetch in the latest Strapi version (v4.6.2).

To Reproduce Steps to reproduce the behavior:

  1. Install the plugin using the latest strapi version (>= v4.6.2)

Expected behavior Application should start with no error.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Strapi v4.6.2 release info: https://github.com/strapi/strapi/releases/tag/v4.6.2 PR deciding to replace request with node-fetch: https://github.com/strapi/strapi/pull/15765

apollocoder commented 1 year ago

I can confirm this as well. If you do not want to wait for the fix, install request as a peer dependency:

npm i request

This is a workaround, either the plugin should switch to node-fetch as well or include request on their own.

octohuguesdumont commented 1 year ago

Hello, we found the same problem with strapi 4.7.1

krisdahl commented 1 year ago

I used yarn add request in the root strapi folder as a workaround.

molul commented 1 year ago

Thanks for the workaround. I couldn't update since 4.6.2 and now I've been able to update to 4.8.2 :)

josephpage commented 1 year ago

Hi all, I've opened PR #98 to replace the obsolete request module with node-fetch (and declaring it in dependencies to avoid future problems), and I'm waiting for review from the maintainer @Baboo7.

dmurphy779 commented 1 year ago

Hi all, I've opened PR #98 to replace the obsolete request module with node-fetch (and declaring it in dependencies to avoid future problems), and I'm waiting for review from the maintainer @Baboo7.

Bump - waiting on a solution before I re-install.

Baboo7 commented 1 year ago

Thank you @josephpage. Just published version 1.18.1 with the fix