fix(import): replace the obsolete request module with node-fetch

Baboo7 / strapi-plugin-import-export-entries

Import/Export data from and to your database in just few clicks.

179 stars 95 forks source link

fix(import): replace the obsolete request module with node-fetch #98

Closed josephpage closed 1 year ago

josephpage commented 1 year ago

This is a (successfull) attempt to solve #96. 🎉

It includes :

rewriting of the function fetchFile to use node-fetch instead of the deprecated request (which is no more used by the Strapi core)
addition of node-fetch (v2.6.9 as this is the version used by Strapi) in the dependencies list to be sure that a "module not found" will not occured in the future any more
alignement of the node/npm requirements with Strapi's ones (node: >=14.19.1 <=18.x.x, npm: >=6.0.0, sourced from the strapi/strapi repo)

Thank you for taking it into consideration!

josephpage commented 1 year ago

Hello @Baboo7, can you take a look at this PR? Thanks a lot!

Yasaman-k commented 1 year ago

I dont have [server/services/import/utils/file.js] this file what I have to replace? also I dont have fetchFile function in my project

jffernandez commented 1 year ago

I dont have [server/services/import/utils/file.js] this file what I have to replace? also I dont have fetchFile function in my project

It's on the plugin source, you can't overwrite it from your project. As a temporal hack, while it's not merged, you can use the fix branch changing in your package.json: "strapi-plugin-import-export-entries": "1.18.0", to: "strapi-plugin-import-export-entries": "github:josephpage/strapi-plugin-import-export-entries#fix-request-module-not-found",