BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
22.78k stars 3.39k forks source link

Nine patch for fox UIs with ideal width and ideal height #15110

Closed RaananW closed 1 month ago

RaananW commented 1 month ago

Playground to test with:

QMQI2Z#5

or

QMQI2Z#1

bjsplat commented 1 month ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

RaananW commented 1 month ago

The general gist - this only changes the scenario to ADTs with idealWidth or idealHeight, which auto-adjusts the size of the image. In this case, it would be expected that the 9 portions of the image would also adjust accordingly. Conversation is here - https://forum.babylonjs.com/t/gui-9-patch-stretch-not-working-well-with-adaptive-scaling/48635?u=raananw

bjsplat commented 1 month ago

Snapshot stored with reference name: refs/pull/15110/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15110/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15110/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15110/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15110/merge https://gui.babylonjs.com/?snapshot=refs/pull/15110/merge https://nme.babylonjs.com/?snapshot=refs/pull/15110/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15110/merge#BCU1XR#0

bjsplat commented 1 month ago

Visualization tests for WebGPU (Experimental) Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15110/merge/testResults/webgpuplaywright/index.html

bjsplat commented 1 month ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15110/merge/testResults/webgl2playwright/index.html