BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
22.78k stars 3.39k forks source link

Replaced voronoi noise code #15117

Closed lockphase closed 1 month ago

lockphase commented 1 month ago

Pls see forum post on voronoi noise node artifact in nme.

bjsplat commented 1 month ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 1 month ago

Snapshot stored with reference name: refs/pull/15117/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15117/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15117/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15117/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15117/merge https://gui.babylonjs.com/?snapshot=refs/pull/15117/merge https://nme.babylonjs.com/?snapshot=refs/pull/15117/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15117/merge#BCU1XR#0

bjsplat commented 1 month ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15117/merge/testResults/webgl2playwright/index.html

bjsplat commented 1 month ago

Visualization tests for WebGPU (Experimental) Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15117/merge/testResults/webgpuplaywright/index.html

Popov72 commented 1 month ago

I'm ok with the changes, the only thing is that it's a breaking change for people who use the existing function and weren't bothered by the bug...

What do you think @sebavan?

deltakosh commented 1 month ago

I believe it is ok. We usually fix bugs even if the previous behavior was acceptable for some users