BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
23.1k stars 3.41k forks source link

Add WebDeviceInputSystem unit tests to cover pointermove before pointerdown cases #15120

Closed AmoebaChant closed 4 months ago

AmoebaChant commented 4 months ago

These unit tests protect against regressions of the fix which addressed the bug where systems which call pointermove before pointedown got the WebDeviceInputSystem into a bad state where it would no longer accept additional touch events. See commit: https://github.com/BabylonJS/Babylon.js/commit/aa2398ea386c16739839384e7d50fb6bfe032f55

bjsplat commented 4 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 4 months ago

Snapshot stored with reference name: refs/pull/15120/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15120/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15120/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15120/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15120/merge https://gui.babylonjs.com/?snapshot=refs/pull/15120/merge https://nme.babylonjs.com/?snapshot=refs/pull/15120/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15120/merge#BCU1XR#0

bjsplat commented 4 months ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15120/merge/testResults/webgl2playwright/index.html

bjsplat commented 4 months ago

Visualization tests for WebGPU (Experimental) Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15120/merge/testResults/webgpuplaywright/index.html