BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
22.78k stars 3.39k forks source link

Fixes and enhancement on Havok & volumes #15130

Closed CedricGuillemet closed 1 month ago

CedricGuillemet commented 1 month ago

Follow up :

Expose Shape aabb from Havok and use absoluteScaling for aggregate volume computation instead of local scaling.

bjsplat commented 1 month ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 1 month ago

Snapshot stored with reference name: refs/pull/15130/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15130/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15130/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15130/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15130/merge https://gui.babylonjs.com/?snapshot=refs/pull/15130/merge https://nme.babylonjs.com/?snapshot=refs/pull/15130/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15130/merge#BCU1XR#0

bjsplat commented 1 month ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15130/merge/testResults/webgl2playwright/index.html

bjsplat commented 1 month ago

Visualization tests for WebGPU (Experimental) Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15130/merge/testResults/webgpuplaywright/index.html

CedricGuillemet commented 1 month ago

Is there a way to make it Garbage Collection free ?

Or is it not intended to be use in the render loop ?

I think it's mostly for debugging purpose. So it should not be called every frame and should not end up being used in production.