BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
22.76k stars 3.39k forks source link

Remove disposed body from physicsViewer #15151

Closed CedricGuillemet closed 1 month ago

CedricGuillemet commented 1 month ago

follow up https://forum.babylonjs.com/t/physicsviewer-crashes-the-application-when-disposing-of-a-physicsbody/50962

bjsplat commented 1 month ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 1 month ago

Snapshot stored with reference name: refs/pull/15151/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15151/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15151/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15151/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15151/merge https://gui.babylonjs.com/?snapshot=refs/pull/15151/merge https://nme.babylonjs.com/?snapshot=refs/pull/15151/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15151/merge#BCU1XR#0

bjsplat commented 1 month ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15151/merge/testResults/webgl2playwright/index.html

bjsplat commented 1 month ago

Visualization tests for WebGPU (Experimental)

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15151/merge/testResults/webgpuplaywright/index.html

sebavan commented 1 month ago

Is it ok to merge, I am seeing comment from popov unresolved ?