search

BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
23.09k stars 3.41k forks source link

Make AbstractMesh a real abstract class #15160

Closed bghgary closed 4 months ago

bghgary commented 4 months ago

Note that some calls to new AbstractMesh were converted to new Mesh instead of new TransformNode because various helper functions still take an AbstractMesh when it could in theory take TransformNode.

bghgary commented 4 months ago

Let's discuss to make sure we are okay with the changes. It is semi-breaking as we will no longer be able to create AbstractMesh objects, which arguably should not be allowed.

bjsplat commented 4 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 4 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 4 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 4 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 4 months ago

Snapshot stored with reference name: refs/pull/15160/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15160/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15160/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15160/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15160/merge https://gui.babylonjs.com/?snapshot=refs/pull/15160/merge https://nme.babylonjs.com/?snapshot=refs/pull/15160/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15160/merge#BCU1XR#0

bjsplat commented 4 months ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15160/merge/testResults/webgl2playwright/index.html

bjsplat commented 4 months ago

Visualization tests for WebGPU (Experimental)

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15160/merge/testResults/webgpuplaywright/index.html