search

BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
23.09k stars 3.41k forks source link

Mesh: Fix back compat for sideOrientation when parsing mesh #15206

Closed Popov72 closed 3 months ago

Popov72 commented 3 months ago

See https://forum.babylonjs.com/t/new-versions-7-10-7-11-have-errors-with-model-normal-maps/51320/6

bjsplat commented 3 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 3 months ago

Snapshot stored with reference name: refs/pull/15206/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15206/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15206/merge https://gui.babylonjs.com/?snapshot=refs/pull/15206/merge https://nme.babylonjs.com/?snapshot=refs/pull/15206/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15206/merge#BCU1XR#0

bjsplat commented 3 months ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl2playwright/index.html

bjsplat commented 3 months ago

Visualization tests for WebGPU (Experimental)

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgpuplaywright/index.html

bjsplat commented 3 months ago

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat commented 3 months ago

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

bjsplat commented 3 months ago

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Popov72 commented 3 months ago

The "NME Shadow Map" test fails in WebGL1 with a "Exceeded timeout of 40000 ms for a test." error, I don't really know why...

I already tried to restart the job, but with no luck.

RaananW commented 3 months ago

Shader error https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=32046&view=logs&j=7b404efb-7538-55b4-a782-4ea3884fcbf6&t=bf9ef5b9-af36-59b6-bc38-ebe764b12ced&l=4324 Screenshot_20240616_092609_Chrome.jpg

Would be better to fix this before merging, even though webgl1 is no longer mandatory.

Popov72 commented 3 months ago

We don't support writing to gl_FragDepth in WebGL1, so I've removed the faulty test from the WebGL1 test suite.