search

BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
23.09k stars 3.41k forks source link

Revert "BoundingBox helper: add batch methods" #15230

Closed deltakosh closed 3 months ago

deltakosh commented 3 months ago

Reverts BabylonJS/Babylon.js#15225

bjsplat commented 3 months ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

deltakosh commented 3 months ago

B8B8Z2#9: this is the one to test

correct:

image

incorrect: image

deltakosh commented 3 months ago

Please do not merge for now. We are not sure yet if we can repro

bjsplat commented 3 months ago

Snapshot stored with reference name: refs/pull/15230/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15230/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15230/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15230/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15230/merge https://gui.babylonjs.com/?snapshot=refs/pull/15230/merge https://nme.babylonjs.com/?snapshot=refs/pull/15230/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15230/merge#BCU1XR#0

bjsplat commented 3 months ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15230/merge/testResults/webgl2playwright/index.html

bjsplat commented 3 months ago

Visualization tests for WebGPU (Experimental)

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15230/merge/testResults/webgpuplaywright/index.html