BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
22.75k stars 3.39k forks source link

Declarations - const enum to enums #15235

Closed RaananW closed 6 days ago

RaananW commented 6 days ago

When preserving const enums (to be available in js) the exported code is identical to a standard export ofr an enum. However, typescript still fails compilation when trying to iterate over it though it will work correctly when used directly in js.

This reverts const enums to enums in our UMD declarations, which will allow any playground using enum iteration in typescript to work.

bjsplat commented 6 days ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 6 days ago

Snapshot stored with reference name: refs/pull/15235/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15235/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15235/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15235/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15235/merge https://gui.babylonjs.com/?snapshot=refs/pull/15235/merge https://nme.babylonjs.com/?snapshot=refs/pull/15235/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15235/merge#BCU1XR#0

bjsplat commented 6 days ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15235/merge/testResults/webgl2playwright/index.html

bjsplat commented 6 days ago

Visualization tests for WebGPU (Experimental)

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15235/merge/testResults/webgpuplaywright/index.html