BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
22.75k stars 3.39k forks source link

modify declaration's const enum to enums #15242

Closed RaananW closed 1 day ago

RaananW commented 2 days ago

Fixes #15238

We can do that since typescript exports the const enums just as if they were enums. The step to use const enums still provides advantages to people consuming the framework, but this way typescript will treat them as regular enums on projects using babylon.

bjsplat commented 2 days ago

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat commented 2 days ago

Snapshot stored with reference name: refs/pull/15242/merge

Test environment: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15242/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15242/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15242/merge https://sandbox.babylonjs.com/?snapshot=refs/pull/15242/merge https://gui.babylonjs.com/?snapshot=refs/pull/15242/merge https://nme.babylonjs.com/?snapshot=refs/pull/15242/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15242/merge#BCU1XR#0

bjsplat commented 2 days ago

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15242/merge/testResults/webgl2playwright/index.html

bjsplat commented 2 days ago

Visualization tests for WebGPU (Experimental)

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15242/merge/testResults/webgpuplaywright/index.html